[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reappearing marks--a clue!



Mark Plaksin <happy@arches.uga.edu> writes:

> I think I've discovered why certain marks reappear.

A wonderful bug report, Thanks!  Could you try this patch?

1999-04-22  Simon Josefsson  <jas@pdc.kth.se>

	* gnus-sum.el (gnus-update-marks): Process null mark lists.

--- gnus-sum.el-        Thu Apr 22 20:55:58 1999
+++ gnus-sum.el Thu Apr 22 20:54:26 1999
@@ -4264,13 +4264,14 @@
        (uncompressed '(score bookmark killed))
        type list newmarked symbol delta-marks)
     (when info
-      ;; Add all marks lists that are non-nil to the list of marks lists.
+      ;; Add all marks lists to the list of marks lists.
       (while (setq type (pop types))
-       (when (setq list (symbol-value
+       (setq list (symbol-value
                          (setq symbol
                                (intern (format "gnus-newsgroup-%s"
                                                (car type))))))
 
+       (when list
          ;; Get rid of the entries of the articles that have the
          ;; default score.
          (when (and (eq (cdr type) 'score)
@@ -4285,7 +4286,7 @@
                    (setcdr prev (cdr arts))
                  (setq prev arts))
                (setq arts (cdr arts)))
-             (setq list (cdr all))))
+             (setq list (cdr all)))))
 
          (when (gnus-check-backend-function 'request-set-mark
                                             gnus-newsgroup-name)
@@ -4305,7 +4306,7 @@
                      (if (memq (cdr type) uncompressed) list
                        (gnus-compress-sequence
                         (set symbol (sort list '<)) t)))
-               newmarked)))
+             newmarked))
 
       (when delta-marks
        (unless (gnus-check-group gnus-newsgroup-name)