[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reappearing marks--a clue!



Simon Josefsson <jas@pdc.kth.se> writes:

> Mark Plaksin <happy@arches.uga.edu> writes:
> 
> > I think I've discovered why certain marks reappear.
> 
> A wonderful bug report, Thanks!  Could you try this patch?

A wonderful patch--thanks! :)  It works great!  Yay!

It didn't apply cleanly to pgnus 0.83; a patch against that is below.  Will
you ship it off to Lars?

Thanks again!

--- gnus-sum.el.orig	Sun Apr 18 08:44:09 1999
+++ gnus-sum.el	Thu Apr 22 16:05:31 1999
@@ -4264,12 +4264,13 @@
 	(uncompressed '(score bookmark killed))
 	type list newmarked symbol delta-marks)
     (when info
-      ;; Add all marks lists that are non-nil to the list of marks lists.
+      ;; Add all marks lists to the list of marks lists.
       (while (setq type (pop types))
-	(when (setq list (symbol-value
+	(setq list (symbol-value
 			  (setq symbol
 				(intern (format "gnus-newsgroup-%s"
 						(car type))))))
+	(when list
 
 	  ;; Get rid of the entries of the articles that have the
 	  ;; default score.
@@ -4285,7 +4286,7 @@
 		    (setcdr prev (cdr arts))
 		  (setq prev arts))
 		(setq arts (cdr arts)))
-	      (setq list (cdr all))))
+	      (setq list (cdr all)))))
 
 	  (when (gnus-check-backend-function 'request-set-mark
 					     gnus-newsgroup-name)
@@ -4305,7 +4306,7 @@
 		      (if (memq (cdr type) uncompressed) list
 			(gnus-compress-sequence
 			 (set symbol (sort list '<)) t)))
-		newmarked)))
+		newmarked))
 
       (when delta-marks
 	(unless (gnus-check-group gnus-newsgroup-name)

-- 
Mark Plaksin                                http://www.arches.uga.edu/~happy/