Re: nnimap 0.3.23

[Simon Josefsson <jas@pdc.kth.se>]

Seth Alves <alves@Hungry.COM> writes:

> I'm also having trouble.  0.3.20 is the most recent version
> that worked for me.

Fritz Heinrichmeyer <fritz.heinrichmeyer@fernuni-hagen.de> writes:

> With or without the login option, it does not work. 
> Version 0.3.22 worked with or without the login setting settings.
> I also use an .authinfo file btw. .

jrp@informix.com (Joshua R. Poulson) writes:

> I had the same problem (also using the UW server), I switched back to
> 0.3.20. I tried to send logs but the mail went into a black hole. I'll
> try to recreate sometime today.

Jake Colman <colman@ppllc.com> writes:

> I am not getting a login prompt when using 0.3.23 and, therefore, am getting
> "server denied" messages.

Could you apply the attached patch and mail me the backtrace?

The problem is that code behind a condition-case has a bug, hence you
only get 'server denied' and no errors.

I tried to fix this in 0.3.23 by nnheader-report'ing the error
returned from condition-case to Gnus, but it could be scrolling by too
fast for us to notice.

Perhaps we shouldn't condition-case until this part of the code has
been tested for a while.... All the re-written login stuff lies here.

--- nnimap.el-  Thu Aug 20 22:01:25 1998
+++ nnimap.el   Thu Aug 20 22:01:47 1998
@@ -423,7 +423,7 @@
                          (string-to-number 
                           (substring nnimap-server-address (1+ pos)))))
               (host (substring nnimap-server-address 0 pos)))
-         (condition-case err
+;        (condition-case err
              ;; todo: do clever things here if nnimap-auth-method is 'smart
              (let ((imap-open-stream (cond ((eq nnimap-auth-method 
                                                 'kerberos4)
@@ -453,15 +453,15 @@
                  ;; authenticate ourself
                  (when (nnimap-authenticate server nnimap-server-buffer)
                    (push (cons server nnimap-server-buffer)
-                         nnimap-server-buffer-alist))))
+                         nnimap-server-buffer-alist))))))))
            ;; Assume error comes from host unknow so we are not connected yet
-           (error (kill-buffer nnimap-server-buffer)
-                  (nnheader-report 'nnimap (cdr err)))
-           (quit (let (imap-last-status)
-                   (imap-close-server nnimap-server-buffer)
-                   (unless (get-buffer nnimap-server-buffer)
-                     (kill-buffer nnimap-server-buffer))
-                   (nnheader-report 'nnimap (cdr err)))))))))
+;          (error (kill-buffer nnimap-server-buffer)
+;                 (nnheader-report 'nnimap (cdr err)))
+;          (quit (let (imap-last-status)
+;                  (imap-close-server nnimap-server-buffer)
+;                  (unless (get-buffer nnimap-server-buffer)
+;                    (kill-buffer nnimap-server-buffer))
+;                  (nnheader-report 'nnimap (cdr err)))))))))
   
 (deffoo nnimap-close-server (&optional server)
   (let ((s-b (assoc